feat(sdk-core): accept SPKI secp256k1 pubs in Ofc.isValidPub#8958
Merged
zahin-mohammad merged 1 commit intoJun 5, 2026
Merged
Conversation
OFC wallets hold keys in two formats: the user key is a BIP-32 base58 xpub and the BitGo key (source: 'bitgo') is a base64-encoded SPKI (DER-wrapped) secp256k1 public key. Ofc.isValidPub previously accepted only the xpub format and wrongly returned false for a legitimate BitGo public key. Extend isValidPub to also accept base64 SPKI secp256k1 keys, reading the curve via KeyObject.asymmetricKeyDetails so wrong-curve keys (e.g. P-256) are rejected. WCN-266 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
zahin-mohammad
force-pushed
the
zahinmohammad/wcn-266-update-ofcisvalidpub-in-sdk-for-happy-path
branch
from
34dc2ca to
c7ab5b1
Compare
mohammadalfaiyazbitgo
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ofc.isValidPubpreviously accepted only BIP-32 base58 xpubs. Phase 3 adds a second key to OFC wallets — the BitGo KMS key (source: 'bitgo') stored as a base64-encoded SPKI (DER-wrapped) secp256k1 public key (raw AWS KMSGetPublicKeyoutput) — which the method wrongly rejected.isValidPubto also accept base64 SPKI secp256k1 keys, with a strictcrv === 'secp256k1'curve check so wrong-curve keys (e.g. P-256) are still rejected.Test plan
cd modules/bitgo && npx mocha test/v2/unit/coins/ofc.ts→ 9 passing@bitgo/sdk-corebuilds cleanTicket: WCN-266
🤖 Generated with Claude Code